Added Optional Roving Tabindex to Toolbar #4557
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoaderB0T
reviewed
Jan 8, 2025
| const currentItem = this.controls[currentIndex][1]; | ||
| currentItem.tabIndex = -1; | ||
|
|
||
| let nextIndex; |
| @@ -133,9 +139,54 @@ class Toolbar extends Module<ToolbarProps> { | |||
| } | |||
| this.update(range); | |||
| }); | |||
|
|
|||
| if (this.hasRovingTabindex && input.tagName === 'BUTTON') { | |||
| input.addEventListener('keydown', (e) => { | |||
| var target = e.currentTarget; | ||
| if (!target) return; | ||
|
|
||
| switch (e.key) { |
There was a problem hiding this comment.
a switch with only one option is a bit strange, no?
| // @ts-expect-error | ||
| label.tabIndex = '0'; | ||
| label.tabIndex = '-1'; |
There was a problem hiding this comment.
should this only happen for non roving or always?
There was a problem hiding this comment.
This is now always set to -1 initially because I handle this in the setTabIndexes() method, which is called later once everything is initialized.
| if (!target) return; | ||
|
|
||
| switch (e.key) { | ||
| case 'ArrowLeft': |
| } | ||
|
|
||
| handleKeyboardEvent(e: KeyboardEvent) { | ||
| if (!this.hasRovingTabindex) return; |
There was a problem hiding this comment.
kind of duplicated. Can't you put the key handler on the toolbar or another parent of both buttons and picker?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not fully done yet, but will include an optional roving tabindex in the toolbar. This is a feature I need in order to have a better User Experience, so that users don't have to tab through each individual item. Rather, they tab into the toolbar, then the editor. Within the toolbar, they can navigate left and right with the ArrowKeys.